Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat (Topology/EMetricSpace): ext lemmas for Extended metric classes #10813

Closed
wants to merge 3 commits into from

Conversation

edegeltje
Copy link
Collaborator

previously the ext tactic would fail for these classes. now it won't.


these lemmas are basically copied over from their non-extended equivalents.

Open in Gitpod

@edegeltje edegeltje added awaiting-review The author would like community review of the PR awaiting-CI t-topology Topological spaces, uniform spaces, metric spaces, filters new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community! labels Feb 21, 2024
@edegeltje edegeltje added the easy < 20s of review time. See the lifecycle page for guidelines. label Feb 29, 2024
Copy link
Collaborator

@loefflerd loefflerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've left a few minor suggestions, otherwise looks fine to me.

Mathlib/Topology/EMetricSpace/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Topology/EMetricSpace/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Topology/EMetricSpace/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Topology/EMetricSpace/Basic.lean Outdated Show resolved Hide resolved
@loefflerd loefflerd added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 19, 2024
@edegeltje edegeltje added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 26, 2024
@loefflerd
Copy link
Collaborator

Great, thanks!

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by loefflerd.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 28, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 28, 2024
…10813)


previously the `ext` tactic would fail for these classes. now it won't.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat (Topology/EMetricSpace): ext lemmas for Extended metric classes [Merged by Bors] - feat (Topology/EMetricSpace): ext lemmas for Extended metric classes Mar 28, 2024
@mathlib-bors mathlib-bors bot closed this Mar 28, 2024
@mathlib-bors mathlib-bors bot deleted the blizzard_inc/pseudo_emetric_space_ext branch March 28, 2024 11:36
Louddy pushed a commit that referenced this pull request Apr 15, 2024
…10813)


previously the `ext` tactic would fail for these classes. now it won't.
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
…10813)


previously the `ext` tactic would fail for these classes. now it won't.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
…10813)


previously the `ext` tactic would fail for these classes. now it won't.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
…10813)


previously the `ext` tactic would fail for these classes. now it won't.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants